Backport to branch(3.9) : Fix status code handling

[feeblefakie]

This is an automated backport of the following:

• Original PR: Fix status code handling #323
• Backported commit: 8458852

Please merge this PR after all checks have passed.

[gemini-code-assist]

Summary of Changes

Hello @feeblefakie, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the system's error handling by ensuring that specific internal status codes are accurately translated into their corresponding gRPC status codes. This enhancement improves the clarity and robustness of error reporting, particularly for scenarios involving invalid arguments and missing secrets, by aligning them with standard gRPC error representations.

Highlights

• Status Code Mapping Enhancement: The convert method in CommonService.java has been updated to correctly map the internal INVALID_ARGUMENT status code to io.grpc.Status.INVALID_ARGUMENT and SECRET_NOT_FOUND to io.grpc.Status.NOT_FOUND.
• Automated Backport: This pull request is an automated backport of an existing fix (Original PR Fix status code handling #323) to the 3.9 branch, ensuring consistency across versions.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly maps the INVALID_ARGUMENT and SECRET_NOT_FOUND status codes to their corresponding gRPC statuses. The changes are straightforward and logically sound. While the code change itself is good, I recommend adding unit tests for these new mappings in CommonServiceTest.java. This would improve test coverage and help prevent future regressions, especially since the private convert method is not directly tested.

[gemini-code-assist]

This switch statement is becoming quite long. With these additions, it's a good time to consider a future refactoring. Using a Map<StatusCode, io.grpc.Status> could make these mappings more declarative and improve maintainability as more status codes are added. This is a suggestion for future improvement and not a blocker for this PR.