Skip to content

Backport to branch(3.9) : Fix status code handling #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jnmt merged 1 commit into from
Dec 3, 2025
Merged

Backport to branch(3.9) : Fix status code handling #341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions common/src/main/java/com/scalar/dl/ledger/server/CommonService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,11 +130,13 @@ private io.grpc.Status convert(StatusCode code) {
case CONTRACT_CONTEXTUAL_ERROR:
case UNLOADABLE_FUNCTION:
case INVALID_FUNCTION:
case INVALID_ARGUMENT:
return io.grpc.Status.INVALID_ARGUMENT;
case CERTIFICATE_NOT_FOUND:
case CONTRACT_NOT_FOUND:
case ASSET_NOT_FOUND:
case FUNCTION_NOT_FOUND:
case SECRET_NOT_FOUND:
return io.grpc.Status.NOT_FOUND;
case CERTIFICATE_ALREADY_REGISTERED:
case SECRET_ALREADY_REGISTERED:
Comment on lines 130 to 142
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This switch statement is becoming quite long. With these additions, it's a good time to consider a future refactoring. Using a Map<StatusCode, io.grpc.Status> could make these mappings more declarative and improve maintainability as more status codes are added. This is a suggestion for future improvement and not a blocker for this PR.

Expand Down