Skip to content

CI: Use scientific-python/upload-nightly-action for nightly wheels #63266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mroeschke wants to merge 4 commits into
base: main
Choose a base branch
from
+5 −50
Open

CI: Use scientific-python/upload-nightly-action for nightly wheels #63266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e3d3043
CI: Don't upload wheels to anaconda.org/multibuild-wheels-staging
mroeschke Dec 4, 2025
c3bbb0d
Merge remote-tracking branch 'upstream/main' into rm/staging_wheels
mroeschke Dec 4, 2025
d7f3411
CI: Use scientific-python/upload-nightly-action for nightly wheels
mroeschke Dec 4, 2025
774a20f
Merge remote-tracking branch 'upstream/main' into ci/nightlies/sp_action
mroeschke Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 5 additions & 14 deletions .github/workflows/wheels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ jobs:
(github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v') && ( ! endsWith(github.ref, 'dev0')))
runs-on: ubuntu-24.04
env:
IS_PUSH: ${{ github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v') }}
IS_SCHEDULE_DISPATCH: ${{ github.event_name == 'schedule' || github.event_name == 'workflow_dispatch' }}
outputs:
sdist_file: ${{ steps.save-path.outputs.sdist_name }}
Expand Down Expand Up @@ -118,7 +117,6 @@ jobs:
python: ["cp313t", "3.13"]

env:
IS_PUSH: ${{ github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v') }}
IS_SCHEDULE_DISPATCH: ${{ github.event_name == 'schedule' || github.event_name == 'workflow_dispatch' }}
steps:
- name: Checkout pandas
Expand Down Expand Up @@ -204,18 +202,11 @@ jobs:
path: ./wheelhouse/*.whl

- name: Upload wheels & sdist
if: ${{ success() && (env.IS_SCHEDULE_DISPATCH == 'true' || env.IS_PUSH == 'true') }}
shell: bash -el {0}
env:
PANDAS_NIGHTLY_UPLOAD_TOKEN: ${{ secrets.PANDAS_NIGHTLY_UPLOAD_TOKEN }}
# trigger an upload to
# https://anaconda.org/scientific-python-nightly-wheels/pandas
# for cron jobs or "Run workflow" (restricted to main branch).
# The tokens were originally generated at anaconda.org
run: |
source ci/upload_wheels.sh
set_upload_vars
upload_wheels
if: ${{ success() && env.IS_SCHEDULE_DISPATCH == 'true' }}
Copy link
Member

@jorisvandenbossche jorisvandenbossche Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of || IS_PUSH here just means that we no longer will push a tagged commit to the nightly channel? (which I suppose is fine, although strictly speaking then there is a brief moment that the nightly channel is behind on PyPI 🤷 )

Copy link
Member Author

@mroeschke mroeschke Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of || IS_PUSH here just means that we no longer will push a tagged commit to the nightly channel?

I suppose so, yes. IMO the day lag between indexes should hopefully be OK. Not sure if other projects have a policy of also publishing their stable releases on the nightly index.

uses: scientific-python/upload-nightly-action@0.6.2
with:
artifacts_path: dist
anaconda_nightly_upload_token: ${{secrets.PANDAS_NIGHTLY_UPLOAD_TOKEN}}

publish:
if: >
Expand Down
36 changes: 0 additions & 36 deletions ci/upload_wheels.sh
View file
Open in desktop

This file was deleted.

Loading