CI: Use scientific-python/upload-nightly-action for nightly wheels #63266
+5
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| source ci/upload_wheels.sh | ||
| set_upload_vars | ||
| upload_wheels | ||
| if: ${{ success() && env.IS_SCHEDULE_DISPATCH == 'true' }} |
Member
There was a problem hiding this comment.
The removal of || IS_PUSH here just means that we no longer will push a tagged commit to the nightly channel? (which I suppose is fine, although strictly speaking then there is a brief moment that the nightly channel is behind on PyPI 🤷 )
Member
Author
There was a problem hiding this comment.
The removal of || IS_PUSH here just means that we no longer will push a tagged commit to the nightly channel?
I suppose so, yes. IMO the day lag between indexes should hopefully be OK. Not sure if other projects have a policy of also publishing their stable releases on the nightly index.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #63265