Update cloud service swagger file and examples #19311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arpitkh12
requested review from
MS-syh2qs,
Sandido,
dkulkarni-ms,
grizzlytheodore,
haagha,
hyonholee and
madewithsmiles
as code owners
|
Hi, @arpitkh12 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Generation Artifacts
|
|
|
|
Hi @arpitkh12, Your PR has some issues. Please fix the CI sequentially by following the order of
|
...ompute/resource-manager/Microsoft.Compute/stable/2022-04-04/CloudServiceRP/cloudService.json
Show resolved
Hide resolved
...ompute/resource-manager/Microsoft.Compute/stable/2022-04-04/CloudServiceRP/cloudService.json
Show resolved
Hide resolved
...ompute/resource-manager/Microsoft.Compute/stable/2022-04-04/CloudServiceRP/cloudService.json
Show resolved
Hide resolved
ArcturusZhang
approved these changes
Jun 6, 2022
Member
ArcturusZhang
left a comment
ArcturusZhang
left a comment
There was a problem hiding this comment.
Approve with one comment
| "settings": { | ||
| "description": "Public settings for the extension. For JSON extensions, this is the JSON settings for the extension. For XML Extension (like RDP), this is the XML setting for the extension.", | ||
| "type": "string" | ||
| "type": "object" |
Contributor
There was a problem hiding this comment.
@arpitkh12 could you provide justification/reason for breaking change here for the breaking change review board?
Contributor
Author
There was a problem hiding this comment.
We have the breaking change because the field return from backend was always a JToken. Historically, this was not being used much or was being set to a string. But now with more extensions being added to CSES and Automatic injection of extension this is impacting customers and has led us to pause rollout of AzSecPack extension. Hence this breaking change
Contributor
There was a problem hiding this comment.
@JeffreyRichter could you please review? even though this PR is merged, it's easier to breaking change here than in our PR to main #19354
|
Hi @arpitkh12, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
1 similar comment
|
Hi @arpitkh12, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
JeffreyRichter
added
the
Approved-BreakingChange
11 tasks
grizzlytheodore
added a commit
that referenced
this pull request
Jun 15, 2022
* set up feature branch * Update cloud service swagger file and examples (#19311) * Update cloud service swagger file and examples * Update cloudService.json Co-authored-by: Arpit Khandelwal <arkhande@microsoft.com> * move systemData object to common.json * Add CloudServiceSlotType to swagger api 2022-04-04 (#19361) Co-authored-by: Arpit Khandelwal <arkhande@microsoft.com> * update with prettier * resolve readme input * add missing example * fix example error, update common with latest change. * set up branch * change folder name * change folder name Co-authored-by: Arpit Khandelwal <arpitkhandelwal@hotmail.com> Co-authored-by: Arpit Khandelwal <arkhande@microsoft.com> Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com>
25 tasks
ArcturusZhang
pushed a commit
that referenced
this pull request
Jun 23, 2022
* set up branch * Feature/cplat 2022 04 04 (#19467) * set up feature branch * Update cloud service swagger file and examples (#19311) * Update cloud service swagger file and examples * Update cloudService.json Co-authored-by: Arpit Khandelwal <arkhande@microsoft.com> * move systemData object to common.json * Add CloudServiceSlotType to swagger api 2022-04-04 (#19361) Co-authored-by: Arpit Khandelwal <arkhande@microsoft.com> * update with prettier * resolve readme input * add missing example * fix example error, update common with latest change. * set up branch * change folder name * change folder name Co-authored-by: Arpit Khandelwal <arpitkhandelwal@hotmail.com> Co-authored-by: Arpit Khandelwal <arkhande@microsoft.com> Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com> * prettier fix Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com> Co-authored-by: Arpit Khandelwal <arpitkhandelwal@hotmail.com> Co-authored-by: Arpit Khandelwal <arkhande@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloud Services Swagger File update to add new API version.
The code changes have already been rolled out and tested. ARM Manifest rollout is currently in progress and would be completed in a week.
What are the changes?