CloudServiceRP Version 2022 04 04 release #19354
Conversation
* Update cloud service swagger file and examples * Update cloudService.json Co-authored-by: Arpit Khandelwal <arkhande@microsoft.com>
|
Hi, @grizzlytheodore Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
1 similar comment
|
Hi, @grizzlytheodore Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
|
Swagger pipeline can not start as the pull request has merge conflicts. |
1 similar comment
|
Swagger pipeline can not start as the pull request has merge conflicts. |
Swagger Generation Artifacts
|
grizzlytheodore
requested review from
MS-syh2qs,
Sandido,
dkulkarni-ms,
haagha,
hyonholee and
madewithsmiles
as code owners
grizzlytheodore
added
the
DoNotMerge
|
Hi @grizzlytheodore, Your PR has some issues. Please fix the CI sequentially by following the order of
|
1 similar comment
|
Hi @grizzlytheodore, Your PR has some issues. Please fix the CI sequentially by following the order of
|
|
What does it mean by: Switch to "Preview" on this description then select one of the choices below.? |
grizzlytheodore
added
the
WaitForARMFeedback
Co-authored-by: Arpit Khandelwal <arkhande@microsoft.com>
|
This PR has not been created correctly. The first commit needs to be the previous api version and the new changes should only be added in the subsequent commits. This is explained in detail here (If using Open API which is recommended) https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/208/OpenAPI-Hub-Adding-new-API-version or here(For manual process) : https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/83/Manual-Process-Adding-new-API-version . Please remove the "ARMChangesRequested" tag once you have fixed this issue. |
openapi-workflow-bot
bot
removed
WaitForARMFeedback
grizzlytheodore
added
the
WaitForARMFeedback
@raosuhas
And also since this branch was created, compute had three releases: 2022-01-03, 2022-03-01, 2022-03-02, and it is a difficult task to keep them all synced. I believe that the difficulty of having the commit history to the ARM team's requirement far outweighs the difficulty added to the review process by the presense of few 'unnecessary' commits. Especially with the PRs I have listed out for you. Please allow an exception |
|
I will need to know what changes are new so that I can review those part, without creating the changes properly I can't tell for sure and it will be hard to go over everything line by line. Can you put all the older changes in a few commits, and add new commit on top of that, so that I can just review the diff from the older commit to the new change? |
|
Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove |
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
|
@zizw123 seriously question, is there an easy/suggested way to do reorganize commits? as a side note, from the very start, every release, we are aware of the ARM review and we do our best to have our commits organized, but again, with all the moving parts, it is very difficult. |
You can create a new branch with the proper commit order and send that as a new PR. That should be easier. The only reason why we are asking for these is that we get a lot of reviews and it's really not ideal to us to go over line by line for every files. |
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.