Skip to content

CloudServiceRP 2022-04-04 #29266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Yao725 merged 0 commits into from
Jun 28, 2022
Merged

CloudServiceRP 2022-04-04 #29266

Yao725 merged 0 commits into from
Jun 28, 2022

Conversation

@grizzlytheodore
Copy link
Contributor

@grizzlytheodore grizzlytheodore commented Jun 13, 2022 •
edited
Loading

Contributing to the Azure SDK

update with CloudService 2022-04-04 version
swagger PR merged: Azure/azure-rest-api-specs#19468

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@ghost ghost added the Compute label Jun 13, 2022
@check-enforcer
Copy link

check-enforcer bot commented Jun 13, 2022

This pull request is protected by Check Enforcer.
For more information about how to run a pipeline against this pull request, see this.

@grizzlytheodore grizzlytheodore marked this pull request as ready for review June 23, 2022 23:32
@grizzlytheodore grizzlytheodore changed the title Feature/cplat 2022 04 04 CloudServiceRP 2022-04-04 Jun 23, 2022
@grizzlytheodore
Copy link
Contributor Author

grizzlytheodore commented Jun 24, 2022

@Yao725 , please review

@grizzlytheodore
Copy link
Contributor Author

grizzlytheodore commented Jun 26, 2022

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jun 26, 2022

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

archerzz
archerzz suggested changes Jun 27, 2022
View reviewed changes
Copy link
Member

@archerzz archerzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grizzlytheodore Can you add the customization for CloudServiceNetworkProfile? For other breaking changes, I could not think of an easy way around. If you could find a way, feel free to add it. Otherwise, leave it alone. Thanks.

Yao725
Yao725 reviewed Jun 27, 2022
View reviewed changes
Copy link
Member

@Yao725 Yao725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't I see any update about compute_resource-manager?

@grizzlytheodore
Copy link
Contributor Author

grizzlytheodore commented Jun 27, 2022

Why don't I see any update about compute_resource-manager?

@Yao725 what do you mean? this is for CloudService version release which is part of Compute service. I believe some CRP related changes in this PR were some things left out from last changes to swagger

@grizzlytheodore
Copy link
Contributor Author

grizzlytheodore commented Jun 27, 2022

@Yao725 @archerzz your comments are addressed. please take a look

@Yao725
Copy link
Member

Yao725 commented Jun 28, 2022 •
edited
Loading

Why don't I see any update about compute_resource-manager?

@Yao725 what do you mean? this is for CloudService version release which is part of Compute service. I believe some CRP related changes in this PR were some things left out from last changes to swagger

@grizzlytheodore , every time when we try to update the sdk, this file should also be updated. This file will help us determine the specific commit in swagger repo. Currently the commit points to the tag: package-2022-03-02 and should be updated, so I'd like to know why this PR doesn't contain this change after you run the script generate.ps1.

@grizzlytheodore
Copy link
Contributor Author

grizzlytheodore commented Jun 28, 2022

@Yao725 oh i see. I've updated it. I missed that step. We usually do it manually. Do you have any documentation on using script generate.ps1. and what it does?

@Yao725
Copy link
Member

Yao725 commented Jun 28, 2022

@Yao725 oh i see. I've updated it. I missed that step. We usually do it manually. Do you have any documentation on using script generate.ps1. and what it does?

We use this script to call the Start-AutoRestCodeGeneration to generate the code, in this script you can specify the resource provider, code generation directory, tag, etc. Here is our doc about how to update track 1 sdk.

@archerzz
Copy link
Member

archerzz commented Jun 28, 2022

@Yao725 Do you have any further comment?

@Yao725
Copy link
Member

Yao725 commented Jun 28, 2022 •
edited
Loading

@Yao725 Do you have any further comment?

No, approved and merged, thank you!

@Yao725 Yao725 merged commit 1f3066e into main Jun 28, 2022
@Yao725 Yao725 deleted the feature/cplat-2022-04-04 branch June 28, 2022 10:35
zhihaoxue pushed a commit to zhihaoxue/azure-sdk-for-net that referenced this pull request Jul 27, 2022
@grizzlytheodore @zhihaoxue
CloudServiceRP 2022-04-04 (Azure#29266)
f391b45 
* set up feature branch

* update

* update

* update recordings

* resolve all tests

* update

* fixes

* credscan sanitize

* update version

* add customization

* Update compute_resource-manager.txt

Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com>
sofiar-msft pushed a commit to sofiar-msft/azure-sdk-for-net that referenced this pull request Dec 7, 2022
@grizzlytheodore @sofiar-msft
CloudServiceRP 2022-04-04 (Azure#29266)
8111c54 
* set up feature branch

* update

* update

* update recordings

* resolve all tests

* update

* fixes

* credscan sanitize

* update version

* add customization

* Update compute_resource-manager.txt

Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yao725 Yao725 Yao725 approved these changes

@fengzhou-msft fengzhou-msft Awaiting requested review from fengzhou-msft

@ArcturusZhang ArcturusZhang Awaiting requested review from ArcturusZhang

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978

@m-nash m-nash Awaiting requested review from m-nash

@markcowl markcowl Awaiting requested review from markcowl

+1 more reviewer

@archerzz archerzz archerzz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Yao725 Yao725

Labels

Compute

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@grizzlytheodore @Yao725 @archerzz