-
Notifications
You must be signed in to change notification settings - Fork 29
Modify Dockerfile to use normal user to run test and reduce binding folder. #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,10 +3,7 @@ | |
| docker run --rm \ | ||
| -e USERNAME="Ipatios Asmanidis" \ | ||
| --net=host \ | ||
| -v "$PWD/output":/output \ | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change breaks existing behaviour (existing output, scripts, reports directories are not longer used), you could just map them to /home/tester/output, /home/tester/scripts, /home/tester/reports. For backwards compatiblity you may also want to add symlinks for the old directories: |
||
| -v "$PWD/suites":/suites \ | ||
| -v "$PWD/scripts":/scripts \ | ||
| -v "$PWD/reports":/reports \ | ||
| -v "$PWD/suites":/home/tester/suites \ | ||
| --security-opt seccomp:unconfined \ | ||
| --shm-size "256M" \ | ||
| ypasmk/robot-framework | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running chrome as not root is not working well.