Modify Dockerfile to use normal user to run test and reduce binding folder. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ap-wtioit
suggested changes
Jan 5, 2022
| # Make sure everything in /home/tester is owned by the build user | ||
| RUN chown -R tester:tester . | ||
|
|
||
| USER tester |
Contributor
There was a problem hiding this comment.
Running chrome as not root is not working well.
| docker run --rm \ | ||
| -e USERNAME="Ipatios Asmanidis" \ | ||
| --net=host \ | ||
| -v "$PWD/output":/output \ |
Contributor
There was a problem hiding this comment.
This change breaks existing behaviour (existing output, scripts, reports directories are not longer used), you could just map them to /home/tester/output, /home/tester/scripts, /home/tester/reports.
For backwards compatiblity you may also want to add symlinks for the old directories:
/output -> /home/tester/output
/suites -> /home/tester/suites
/scripts -> /home/tester/scripts
/reports -> /home/tester/reports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.