Skip to content

MAINT: Deselect logistic regression cases that fail from small numeric differences #2757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 4, 2025
Merged

MAINT: Deselect logistic regression cases that fail from small numeric differences #2757

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5db1752
deselect cases that fail due to expected small numeric differences
david-cortes-intel Oct 29, 2025
3133e7e
deduplicate
david-cortes-intel Oct 30, 2025
dcee7e6
Update deselected_tests.yaml
ethanglaser Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions deselected_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,8 @@ deselected_tests:
- ensemble/tests/test_voting.py::test_sample_weight >=1.0,<1.1
- tests/test_multioutput.py::test_multiclass_multioutput_estimator_predict_proba
- model_selection/tests/test_search.py::test_search_cv_sample_weight_equivalence[estimator0]
- tests/test_calibration.py::test_calibrated_classifier_cv_double_sample_weights_equivalence < 1.1
- tests/test_common.py::test_estimators[StackingClassifier(estimators=[('est1',LogisticRegression(C=0.1)) < 1.1
Copy link
Contributor

@ethanglaser ethanglaser Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but it appears neither deselection is picked up. For top one I am guessing it is because we already have this exact same deselection https://github.com/uxlfoundation/scikit-learn-intelex/blob/main/deselected_tests.yaml#L298, so maybe it makes sense to remove the original line and version from this one. For second line I think the deselection logic is dicey with parenthesis and possibly quotes. Best to confirm it works locally.

Copy link
Contributor Author

@david-cortes-intel david-cortes-intel Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.


# Scikit-learn does not constraint multinomial logistic intercepts to sum to zero.
# Softmax function is invariant to additions by a constant, so even though the numbers
Expand Down
Loading