-
Notifications
You must be signed in to change notification settings - Fork 184
MAINT: Deselect logistic regression cases that fail from small numeric differences #2757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Deselect logistic regression cases that fail from small numeric differences #2757
Conversation
|
/intelci: run |
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
deselected_tests.yaml
Outdated
| - tests/test_calibration.py::test_calibrated_classifier_cv_double_sample_weights_equivalence < 1.1 | ||
| - tests/test_common.py::test_estimators[StackingClassifier(estimators=[('est1',LogisticRegression(C=0.1)) < 1.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good but it appears neither deselection is picked up. For top one I am guessing it is because we already have this exact same deselection https://github.com/uxlfoundation/scikit-learn-intelex/blob/main/deselected_tests.yaml#L298, so maybe it makes sense to remove the original line and version from this one. For second line I think the deselection logic is dicey with parenthesis and possibly quotes. Best to confirm it works locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
|
/intelci: run |
|
@ethanglaser @icfaust Looks like it's still executing this deselected test for sklearn==1.0.2: Any ideas about what's happening here? |
|
For second line I think the deselection logic is dicey with parenthesis and possibly quotes. Best to confirm it works locally. I did take a brief look at this late last week and was unable to figure out the best way to deselect this specific subset of tests but I can take a closer look today. |
|
Update: issue is with the whitespace between "<" and "1.1" Also I suggest fully writing out the test name, as there are 50+ tests that get deselected by the current string |
|
/intelci: run |
There's dozens of failures from parametrizations of this test depending on the machine. This should cover all the cases where in theory these small differences could show, even if they aren't failing right now. |
Description
Deselects a few conformance tests that started failing with deviances in the order of 1e-6 after this PR: #2752
Checklist:
Completeness and readability
Testing