Adds read-only mode to Color Picker Property Editor #2451
Conversation
Implemented the read-only mode of the Color Picker Property Editor UI to close umbraco/Umbraco-CMS#17045.
|
Awaiting the update to UUI 1.11.0, then we can get this updated and included. |
| (swatch) => html` | ||
| <uui-color-swatch label=${swatch.label} value=${swatch.value} .showLabel=${this.showLabels}></uui-color-swatch> | ||
| <uui-color-swatch | ||
| ?readonly=${this.readonly} |
There was a problem hiding this comment.
@iOvergaard does it need to set this as readonly on uui-color-swatches explicit set readonly on uui-color-swatch?
https://github.com/umbraco/Umbraco.UI/pull/932/files#diff-8090b44f925ed46b626e45b3d05f30d71d493772a9ddf02effbb81f86c088475R99
There was a problem hiding this comment.
It doesn't set disabled attribute here either ;)
There was a problem hiding this comment.
@bjarnef Good point, but it doesn't look like it's hurting anything setting disabled explicitly. Would you like to make a PR with the disabled attribute?
There was a problem hiding this comment.
I guess _handleSlotChange may execute after so it would override? If <uui-color-swatch> e.g. inside <uui-color-swatches> is set to disabled or readonly, but <uui-colors-swatches> isn't, I guess the swatch is still disabled/readonly as it only explicit handle disbled and readonly.
I guess we may need an else to remove attribute as well in <uui-colors-swatches> even though <uui-colors-swatch> is set to disabled or readonly?
https://github.com/umbraco/Umbraco.UI/pull/932/files#diff-8090b44f925ed46b626e45b3d05f30d71d493772a9ddf02effbb81f86c088475R91-R101
|
Hi there @richarth! First of all: A big #H5YR for making an Umbraco related contribution during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing 🥇 Due to the amazing work you and others in the community have been doing, we've had a bit of a hard time keeping up. 😅 While all of the PRs for Hacktoberfest might not have been merged yet, you still qualify for receiving some Umbraco swag, congratulations! 🎉 In the spirit of Hacktoberfest we've prepared some exclusive Umbraco swag for all our contributors - including you! As an alternative choice, you can opt-out of receiving anything and ask us to help improve the planet instead by planting a tree on your behalf. 🌳 Receive your swag or plant a tree! 👈 Please follow this link to fill out and submit the form, before December 25th, 2024, 23:59:00 UTC. Following this date we'll be sending out all the swag, but please note that it might not reach your doorstep for a few weeks/months, so please bear with us and be patient 🙏 The only thing left to say is thank you so much for participating in Hacktoberfest! We really appreciate the help! Kind regards, |
4 participants
Implemented the read-only mode of the Color Picker Property Editor UI to close umbraco/Umbraco-CMS#17045.