Skip to content
This repository was archived by the owner on Nov 6, 2025. It is now read-only.

Conversation

@iOvergaard
Copy link
Collaborator

@iOvergaard iOvergaard commented Oct 14, 2024

Description

fix: only set the ?readonly attribute on the swatches element since it handles setting it on the colors afterwards based on this comment: #2451 (comment)

CC @bjarnef - is this reasonable?

…t handles setting it on the colors afterwards
@iOvergaard iOvergaard added type/bug ignore-for-release Pull requests that will not be included in the automated release notes. labels Oct 14, 2024
@bjarnef
Copy link
Contributor

bjarnef commented Oct 14, 2024

@iOvergaard yes :)

I think we need to remove disabled and readonly attributes as well in case developer actually set disabled or readonly on nested <uui-color-swatch> element. I think <uui-color-swatches> then decide:
https://github.com/umbraco/Umbraco.UI/blob/v1/contrib/packages/uui-color-swatches/lib/uui-color-swatches.element.ts#L91-L100

I haven't checked that scenario though, but the swatches would probably be rendered as is.

@iOvergaard
Copy link
Collaborator Author

Maybe yeah, @bjarnef. Thanks for the glance, though!

@iOvergaard iOvergaard merged commit d8b81ac into main Oct 14, 2024
@iOvergaard iOvergaard deleted the v15/bugfix/inputcolor-only-on-host branch October 14, 2024 09:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ignore-for-release Pull requests that will not be included in the automated release notes. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants