Skip to content

History: Take URL objects into consideration when storing Backoffice history #20986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 1, 2025
Merged

History: Take URL objects into consideration when storing Backoffice history #20986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4eeb47
fix: allows URL to be passed to navigator
iOvergaard Nov 28, 2025
b0158f1
Also adds fix to Block workspace
leekelleher Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/Umbraco.Web.UI.Client/src/packages/block/block/workspace/block-workspace.context.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { UmbBlockDataModel, UmbBlockDataValueModel, UmbBlockLayoutBaseModel } from '../types.js';

Check notice on line 1 in src/Umbraco.Web.UI.Client/src/packages/block/block/workspace/block-workspace.context.ts

View check run for this annotation

CodeScene Delta Analysis / CodeScene Code Health Review (main)

✅ No longer an issue: String Heavy Function Arguments 

The ratio of strings in function arguments is no longer above the threshold
import { UMB_BLOCK_ENTRIES_CONTEXT, UMB_BLOCK_MANAGER_CONTEXT } from '../context/index.js';
import { UmbBlockWorkspaceEditorElement } from './block-workspace-editor.element.js';
import { UmbBlockElementManager } from './block-element-manager.js';
Expand Down Expand Up @@ -313,11 +313,14 @@
/**
* Check if the workspace is about to navigate away.
* @protected
* @param {string} newUrl The new url that the workspace is navigating to.
* @returns { boolean} true if the workspace is navigating away.
* @param {string | URL} newUrl The new url that the workspace is navigating to.
* @returns {boolean} true if the workspace is navigating away.
* @memberof UmbEntityWorkspaceContextBase
*/
protected _checkWillNavigateAway(newUrl: string): boolean {
protected _checkWillNavigateAway(newUrl: string | URL): boolean {
if (newUrl instanceof URL) {
newUrl = newUrl.href;
}
return !newUrl.includes(this.routes.getActiveLocalPath());
}

Expand Down
9 changes: 6 additions & 3 deletions ...o.Web.UI.Client/src/packages/core/workspace/entity-detail/entity-detail-workspace-base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,11 +376,14 @@ export abstract class UmbEntityDetailWorkspaceContextBase<
/**
* Check if the workspace is about to navigate away.
* @protected
* @param {string} newUrl The new url that the workspace is navigating to.
* @returns { boolean} true if the workspace is navigating away.
* @param {string | URL} newUrl The new url that the workspace is navigating to.
* @returns {boolean} true if the workspace is navigating away.
* @memberof UmbEntityWorkspaceContextBase
*/
protected _checkWillNavigateAway(newUrl: string): boolean {
protected _checkWillNavigateAway(newUrl: string | URL): boolean {
if (newUrl instanceof URL) {
newUrl = newUrl.href;
}
return !newUrl.includes(this.routes.getActiveLocalPath());
}

Expand Down
Loading