History: Take URL objects into consideration when storing Backoffice history
#20986
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where URL objects were not properly handled when storing backoffice history. Following changes in #20928 that allowed URLs to be passed as objects, the _checkWillNavigateAway method needed to be updated to handle both string and URL object types.
Key Changes
- Updated
_checkWillNavigateAwaymethod signature to acceptstring | URLparameter type - Added type guard to convert
URLobjects to strings using.hrefproperty before string operations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows
URLobjects to be passed to the history navigator.This is a bug caused by a change in #20928 where navigated URLs now can be entire objects.
How to test