-
Notifications
You must be signed in to change notification settings - Fork 3
Rover details #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Rover details #24
Changes from 16 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
e77a95c
Fetch mission manifest and sol data for particular rover
b4c163f
Fetch mission manifest and sol data for particular rover
84ac09b
display manifest in desktop format
095b143
added responsive styling for mobile
0b375d1
error handling in MissionManifest component
c57ff46
added globalStyle sheet
85ffbc3
added MissionManifest test file
23aa655
added unit tests
ed71787
ran lint-fix
e038dd1
created button functionality and desktop styling
7f2020a
added styling for mobile and tablet
6e64d5d
fixed lint issues
c0abfc6
merged with main
ef27196
integrated RoverImages Element
cba09bc
fixed lint errors
8a20857
changed scroll bar styling
5c49abd
updated rover imager component
46596d6
fixed Enum naming
539bd5b
added all function components
9325456
fixed apikey build error
c120bb4
fixed apikey build error
fad488b
fixed apikey build error
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,6 +8,9 @@ | |
| # testing | ||
| /coverage | ||
|
|
||
| # api key | ||
| .env | ||
|
|
||
| # production | ||
| /build | ||
|
|
||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,9 @@ | ||
| import React from "react"; | ||
| import "./App.scss"; | ||
| import { BrowserRouter as Router, Routes, Route } from "react-router-dom"; | ||
| import PhotoOfTheDay from "./Components/photoOfTheDay/photoOfTheDay"; | ||
| import RoverDetails from "./Components/RoverDetails/RoverDetails"; | ||
|
|
||
| function App() { | ||
| return ( | ||
| <Router> | ||
| <Routes> | ||
| <Route path="/" element={<PhotoOfTheDay />} /> | ||
| </Routes> | ||
| </Router> | ||
| ); | ||
| return <RoverDetails />; | ||
| } | ||
|
|
||
| export default App; | ||
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you handle the merge here you can do this,
<Route path="/" element={ <> <PhotoOfTheDay /> <RoverDetails /> </> } />