Rover details #24
Merged
Rover details #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
May 20, 2025 14:50
✅ Deploy Preview for gregarious-otter-866740 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
added 2 commits
May 22, 2025 16:05
src/App.tsx
Outdated
| </Routes> | ||
| </Router> | ||
| ); | ||
| return <RoverDetails />; |
Contributor
There was a problem hiding this comment.
When you handle the merge here you can do this,
<Route path="/" element={ <> <PhotoOfTheDay /> <RoverDetails /> </> } />
| ) | ||
| .then((response) => response.json()) | ||
| .then((response) => { | ||
| const data = response.photo_manifest; |
Contributor
There was a problem hiding this comment.
I won't delay getting this merged for this, but have a think about what you would happen if the API call failed and data was undefined
Collaborator
Author
There was a problem hiding this comment.
thank you for pointing it out.
eleanorscott97
requested changes
May 22, 2025
| import "./RoverDetails.scss"; | ||
| import RoverImages from "../RoverImages/RoverImages"; | ||
|
|
||
| export enum rovers { |
Contributor
There was a problem hiding this comment.
The enum should be capitalised
added 2 commits
May 23, 2025 10:34
eleanorscott97
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We completed the following:-