Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/TestExplorer/TestExplorer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import { SwiftLogger } from "../logging/SwiftLogger";
import { buildOptions, getBuildAllTask } from "../tasks/SwiftTaskProvider";
import { TaskManager } from "../tasks/TaskManager";
import { SwiftExecOperation, TaskOperation } from "../tasks/TaskQueue";
import { compositeDisposable, getErrorDescription } from "../utilities/utilities";
import { getErrorDescription } from "../utilities/utilities";
import { Version } from "../utilities/version";
import { parseTestsFromDocumentSymbols } from "./DocumentSymbolTestDiscovery";
import { LSPTestDiscovery } from "./LSPTestDiscovery";
Expand Down Expand Up @@ -208,7 +208,7 @@ export class TestExplorer {
}
});

return compositeDisposable(endProcessDisposable, didChangeSwiftFileDisposable);
return vscode.Disposable.from(endProcessDisposable, didChangeSwiftFileDisposable);
}

/**
Expand All @@ -229,7 +229,7 @@ export class TestExplorer {
break;
}
});
return compositeDisposable(tokenSource, disposable);
return vscode.Disposable.from(tokenSource, disposable);
}

/**
Expand Down
7 changes: 1 addition & 6 deletions src/debugger/debugAdapterFactory.ts
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,7 @@ export function registerDebugger(workspaceContext: WorkspaceContext): vscode.Dis
register();
}

return {
dispose: () => {
configurationEvent.dispose();
subscriptions.map(sub => sub.dispose());
},
};
return vscode.Disposable.from(configurationEvent, ...subscriptions);
}

/**
Expand Down
6 changes: 1 addition & 5 deletions src/debugger/logTracker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,7 @@ export function registerLoggingDebugAdapterTracker(): vscode.Disposable {
];

// Return a disposable that cleans everything up.
return {
dispose() {
subscriptions.forEach(sub => sub.dispose());
},
};
return vscode.Disposable.from(...subscriptions);
}

/**
Expand Down
13 changes: 0 additions & 13 deletions src/utilities/utilities.ts
Original file line number Diff line number Diff line change
Expand Up @@ -457,16 +457,3 @@ export function destructuredPromise<T>(): {
return { promise: p, resolve: resolve!, reject: reject! };
}
/* eslint-enable @typescript-eslint/no-explicit-any */

/**
* Creates a composite disposable from multiple disposables.
* @param disposables The disposables to include.
* @returns A composite disposable that disposes all included disposables.
*/
export function compositeDisposable(...disposables: vscode.Disposable[]): vscode.Disposable {
return {
dispose: () => {
disposables.forEach(d => d.dispose());
},
};
}