Use vscode.Disposable.from instead of compositeDisposable
#1980
+5
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up the codebase so that it uses the built in `vscode.Disposable.from` to dispose multiple disposables at the same time. This replaces our own `compositeDisposable` method. Docs here: https://code.visualstudio.com/api/references/vscode-api#Disposable
plemarquand
requested review from
0xTim,
adam-fowler and
award999
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clean up the codebase so that it uses the built in
vscode.Disposable.fromto dispose multiple disposables at the same time. This replaces our owncompositeDisposablemethod.Docs here: https://code.visualstudio.com/api/references/vscode-api#Disposable
Tasks
Required tests have been writtenDocumentation has been updatedAdded an entry to CHANGELOG.md if applicable