Skip to content

[FileManager] Fix off by one error #1624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AZero13 wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

[FileManager] Fix off by one error #1624

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/FoundationEssentials/FileManager/FileManager+Basics.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ internal struct _FileManagerImpl {
return false
}
}
if readBytes < -1 { return false }
if readBytes < 0 { return false }
Copy link
Contributor

@jmschonfeld jmschonfeld Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a unit test that could be added to validate this behavior to confirm that the change works as intended and it doesn't regress in the future?

Copy link
Contributor Author

@AZero13 AZero13 Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How am I supposed to make a unit test that causes read, an OS syscall, to fail reliably?

return true
}
}
Expand Down