[FileManager] Fix off by one error #1624
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check for readBytes being less than 0, not -1
Contributor
Author
|
@itingliu Hi, could you please check this |
Contributor
Author
jmschonfeld
reviewed
Dec 5, 2025
| } | ||
| } | ||
| if readBytes < -1 { return false } | ||
| if readBytes < 0 { return false } |
Contributor
There was a problem hiding this comment.
Is there a unit test that could be added to validate this behavior to confirm that the change works as intended and it doesn't regress in the future?
Contributor
Author
There was a problem hiding this comment.
How am I supposed to make a unit test that causes read, an OS syscall, to fail reliably?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for readBytes being less than 0, not -1.
It returns -1 when there's an error