-
Notifications
You must be signed in to change notification settings - Fork 6
Evaluate without impressions: add impressionsDisabled option to feature evaluation
#452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
EmilianoSanchez
wants to merge
13
commits into
development
Choose a base branch
from
evaluate-without-impressions
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
f4df1c9
feat: add impressionsDisabled option to feature evaluation
EmilianoSanchez 23818e1
Merge main
ZamoraEmmanuel dd9a447
split impressionsDisabled from properties
ZamoraEmmanuel f121304
Validate impressionsDisabled type
ZamoraEmmanuel 57e244f
Remove innecesary boolean validation
ZamoraEmmanuel f5b6960
update changes file
ZamoraEmmanuel 0d75c9e
Merge branch 'ss-preset' of github.com:splitio/javascript-commons int…
ZamoraEmmanuel 7be328b
Update CHANGES.txt
EmilianoSanchez 25bd071
Merge branch 'development' of github.com:splitio/javascript-commons i…
ZamoraEmmanuel fba8bb8
Remove impressionsDisabled property from ts definitions
ZamoraEmmanuel e161a9e
Merge branch 'evaluate-without-impressions' of github.com:splitio/jav…
ZamoraEmmanuel f26c5c7
Fix lint
ZamoraEmmanuel 226bc67
Update CHANGES.txt
EmilianoSanchez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would need to refactor the
validateEvaluationOptionsso that theimpressionsDisabledoption is only validated and used for the Evaluator, and for other SDKs it should be sanitized tofalse(or any other falsy value) to ignore the feature.Eventually, if the feature is included in SDKs, the change can be rolled back.