Evaluate without impressions: add impressionsDisabled option to feature evaluation
#452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilianoSanchez
changed the title
impressionsDisabled option to feature evaluation [WIP]
ZamoraEmmanuel
changed the title
impressionsDisabled option to feature evaluation [WIP]impressionsDisabled option to feature evaluation
EmilianoSanchez
commented
Dec 12, 2025
| return properties && Object.keys(properties).length > 0 ? { properties } : undefined; | ||
| let options = properties && Object.keys(properties).length > 0 ? { properties } : undefined; | ||
|
|
||
| const impressionsDisabled = maybeOptions.impressionsDisabled; |
Contributor
Author
There was a problem hiding this comment.
We would need to refactor the validateEvaluationOptions so that the impressionsDisabled option is only validated and used for the Evaluator, and for other SDKs it should be sanitized to false (or any other falsy value) to ignore the feature.
Eventually, if the feature is included in SDKs, the change can be rolled back.
EmilianoSanchez
commented
Dec 12, 2025
| * | ||
| * @defaultValue `false` | ||
| */ | ||
| impressionsDisabled?: boolean; |
Contributor
Author
There was a problem hiding this comment.
We should delete this TypeScript definition, if the feature is not supported yet for SDKs.
EmilianoSanchez
commented
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JavaScript commons library
What did you accomplish?
How do we test the changes introduced in this PR?
Extra Notes