chore(len_without_is_empty): extract to a separate module #16195
+352
−338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
needs-fcp
S-waiting-on-review
Collaborator
Contributor
Author
Collaborator
|
Error: Parsing relabel command in comment failed: ...'d on https' | error: a label delta at >| '://github.'... Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip. |
rustbot
added
the
S-blocked
ada4a
force-pushed
the
split-off-len_without_is_empty
branch
from
748c432 to
badf663
Compare
llogiq
approved these changes
Dec 5, 2025
It didn't share any logic at all with the lints in `len_zero.rs`, whereas the helper functions were partially mixed together, so that the file was hard to navigate
ada4a
force-pushed
the
split-off-len_without_is_empty
branch
from
badf663 to
2081b7a
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It didn't share any logic at all with the lints in
len_zero.rs,whereas the helper functions were partially mixed together, so that the
file was hard to navigate
changelog: none