Skip to content

fix(len_without_is_empty): allow is_empty(&self) with len(&mut self) #16194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
llogiq merged 2 commits into from
Dec 5, 2025
Merged

fix(len_without_is_empty): allow is_empty(&self) with len(&mut self) #16194

llogiq merged 2 commits into from
Dec 5, 2025

Conversation

@ada4a
Copy link
Contributor

@ada4a ada4a commented Dec 5, 2025

Fixes #16190

changelog: [len_without_is_empty]: allow is_empty(&self) with len(&mut self)

Diff best viewed with whitespace ignored

ada4a added 2 commits December 5, 2025 13:58
@ada4a
clean-up
a27bd22 
This mostly qualifies variable names with either `is_empty_` or `len_`,
to make it easier to understand which of the two methods they relate to
@ada4a
fix(len_without_is_empty): allow is_empty(&self) with len(&mut self)
d6b5613
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 5, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 5, 2025

r? @samueltardieu

rustbot has assigned @samueltardieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@ada4a ada4a mentioned this pull request Dec 5, 2025
Merged
@llogiq
Copy link
Contributor

llogiq commented Dec 5, 2025

r? @llogiq because this blocks #16195 which I'm reviewing. Sorry Samuel.

@rustbot rustbot assigned llogiq and unassigned samueltardieu Dec 5, 2025
llogiq
llogiq approved these changes Dec 5, 2025
View reviewed changes
Copy link
Contributor

@llogiq llogiq left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

View changes since this review

@llogiq llogiq added this pull request to the merge queue Dec 5, 2025
Merged via the queue into rust-lang:master with commit 28c1eec Dec 5, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 5, 2025
@ada4a ada4a deleted the len_without_is_empty branch December 5, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@llogiq llogiq llogiq approved these changes

Assignees

@llogiq llogiq

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

len_without_is_empty is over-zealous about &mut

4 participants

@ada4a @rustbot @llogiq @samueltardieu