-
Notifications
You must be signed in to change notification settings - Fork 220
remove prometheus metrics #3053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6abc2cc to
965de03
Compare
|
Seems like you forgot to update a docker file. |
can you see the actual error? I seem to miss it in the logs |
|
No, just: So I just assumed (maybe incorrectly) that a docker image needed to be updated. |
|
odd. I'll try locally |
|
ah, I think I know why |
|
I used the metrics endpoints as health-checks for most containers :) |
|
So I was right, yeay me. \o/ |
|
Looks good to me, thanks! |
I'll still wait until CI passes :) |
|
just confirmed again by @marcoieni : rust-lang/simpleinfra#832 is applied, the collectors don't collect any more. |
needs rust-lang/simpleinfra#832 to be merged & applied before deploying, so the collector doesn't run wild.thanks @marcoieni !This also removes the "crates / releases / targets visited" metrics. I didn't look at them for quite some time. There was an initial learning we had (= most requests are crawlers), but nothing else after that, so we can safe the processing time & memory.
If we feel like adding it back, we easily can.