remove more unused dependencies, add cargo-machete #3063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
syphar
force-pushed
the
remove-more-unused-deps
branch
from
9eb2b10 to
9d546d4
Compare
GuillaumeGomez
approved these changes
Dec 2, 2025
Member
GuillaumeGomez
left a comment
GuillaumeGomez
left a comment
There was a problem hiding this comment.
Less dependencies! \o/
syphar
force-pushed
the
remove-more-unused-deps
branch
2 times, most recently
from
d534ec1 to
7283610
Compare
syphar
force-pushed
the
remove-more-unused-deps
branch
from
7283610 to
d494c5a
Compare
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uuidwas used in the cloudfront logic (removed in remove cloudfront support & invalidation queueing #3059)string_cacheand its codegen was used for the "targets-visited" metric thing. so gone with remove prometheus metrics #3053another 11 dependencies gone from the tree ;)
Seeing how often I forget that, I added
cargo macheteto CI. While it has a couple of false positives, which lead to ignore-lists in ourCargo.toml, but it is fast and would have caught all my recent mistakes. Also it needed a workaround for our build-test crates.