skip crate-delete when there is no crate, also remove it from the build queue #3046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
S-waiting-on-review
syphar
force-pushed
the
missing-crate-2
branch
from
81078b9 to
05582a5
Compare
syphar
force-pushed
the
missing-crate-2
branch
from
05582a5 to
97bc01f
Compare
GuillaumeGomez
approved these changes
Nov 29, 2025
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With crate authors being able to delete releases / crates themselves, we have to handle some new cases, for example that we get a crate-delete request and the crate is still just queued.
Mainly coming from this sentry error.
Examples:
This PR does two things: