kk

Author: syphar

src/build_queue.rs

@@ -887,12 +887,10 @@ FROM crates AS c
 mod tests {
     use super::*;
     use crate::db::types::BuildStatus;
-    use crate::test::{FakeBuild, TestEnvironment, V1, V2};
+    use crate::test::{FakeBuild, KRATE, TestEnvironment, V1, V2};
     use chrono::Utc;
     use std::time::Duration;
 
-    static KRATE: &str = "krate";
-
     #[tokio::test(flavor = "multi_thread")]
     async fn test_rebuild_when_old() -> Result<()> {
         let env = TestEnvironment::with_config(

src/db/delete.rs

@@ -209,7 +209,7 @@ mod tests {
     use crate::db::ReleaseId;
     use crate::registry_api::{CrateOwner, OwnerKind};
     use crate::storage::{CompressionAlgorithm, rustdoc_json_path};
-    use crate::test::{V1, V2, async_wrapper, fake_release_that_failed_before_build};
+    use crate::test::{KRATE, V1, V2, async_wrapper, fake_release_that_failed_before_build};
     use test_case::test_case;
 
     async fn crate_exists(conn: &mut sqlx::PgConnection, name: &str) -> Result<bool> {
@@ -527,4 +527,35 @@ mod tests {
             Ok(())
         })
     }
+
+    #[tokio::test(flavor = "multi_thread")]
+    async fn test_delete_missing_crate_doesnt_error() -> Result<()> {
+        let env = crate::test::TestEnvironment::new().await?;
+
+        let db = env.async_db();
+        let mut conn = db.async_conn().await;
+
+        assert!(!crate_exists(&mut conn, KRATE).await?);
+        delete_crate(&mut conn, env.async_storage(), env.config(), KRATE).await?;
+
+        assert!(!crate_exists(&mut conn, KRATE).await?);
+
+        Ok(())
+    }
+
+    #[tokio::test(flavor = "multi_thread")]
+    async fn test_delete_missing_version_doesnt_error() -> Result<()> {
+        let env = crate::test::TestEnvironment::new().await?;
+
+        let db = env.async_db();
+        let mut conn = db.async_conn().await;
+
+        assert!(!crate_exists(&mut conn, KRATE).await?);
+
+        delete_version(&mut conn, env.async_storage(), env.config(), KRATE, &V1).await?;
+
+        assert!(!crate_exists(&mut conn, KRATE).await?);
+
+        Ok(())
+    }
 }

src/test/mod.rs

@@ -41,6 +41,8 @@ use tokio::{runtime, task::block_in_place};
 use tower::ServiceExt;
 use tracing::error;
 
+// testing krate name constants
+pub(crate) const KRATE: &str = "krate";
 // some versions as constants for tests
 pub(crate) const V0_1: Version = Version::new(0, 1, 0);
 pub(crate) const V1: Version = Version::new(1, 0, 0);