-
Notifications
You must be signed in to change notification settings - Fork 344
fix: openshift-gitops-operator-metrics-monitor ServiceMonitor is attempting to use a bearerTokenFile configuration in its endpoints definition #1005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
openshift-merge-bot
merged 7 commits into
redhat-developer:master
from
akhilnittala:usr/akhil/GITOPS-7992
Nov 25, 2025
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
227c865
fix: openshift-gitops-operator-metrics-monitor ServiceMonitor is atte…
akhilnittala 03012b6
Merge branch 'master' into usr/akhil/GITOPS-7992
akhilnittala 82fc6ed
fix: openshift-gitops-operator-metrics-monitor ServiceMonitor is atte…
akhilnittala 9d22845
fix: openshift-gitops-operator-metrics-monitor ServiceMonitor is atte…
akhilnittala 254fae4
fix: openshift-gitops-operator-metrics-monitor ServiceMonitor is atte…
akhilnittala 4a3c072
fix: openshift-gitops-operator-metrics-monitor ServiceMonitor is atte…
akhilnittala c991018
fix: openshift-gitops-operator-metrics-monitor ServiceMonitor is atte…
akhilnittala File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
bundle/manifests/openshift-gitops-operator-metrics-bearer-token_v1_secret.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| apiVersion: v1 | ||
| kind: Secret | ||
| metadata: | ||
| annotations: | ||
| kubernetes.io/service-account.name: openshift-gitops-operator-controller-manager | ||
| name: openshift-gitops-operator-metrics-bearer-token | ||
| type: kubernetes.io/service-account-token | ||
10 changes: 10 additions & 0 deletions
10
bundle/manifests/openshift-gitops-operator-metrics-monitor-ca-bundle_v1_configmap.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| apiVersion: v1 | ||
| kind: ConfigMap | ||
| metadata: | ||
| annotations: | ||
| openshift.io/description: This ConfigMap is used for Prometheus monitoring of | ||
| the GitOps Operator. | ||
| openshift.io/display-name: GitOps Operator Prometheus Monitor ConfigMap | ||
| openshift.io/owning-component: service-ca | ||
| service.beta.openshift.io/inject-cabundle: "true" | ||
| name: openshift-gitops-operator-metrics-monitor-ca-bundle |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,46 @@ | ||
|
|
||
| # Prometheus Monitor Service (Metrics) | ||
| --- | ||
| apiVersion: v1 | ||
| kind: Secret | ||
| metadata: | ||
| name: metrics-bearer-token | ||
| namespace: openshift-gitops-operator | ||
| annotations: | ||
| kubernetes.io/service-account.name: openshift-gitops-operator-controller-manager | ||
| type: kubernetes.io/service-account-token | ||
| --- | ||
| apiVersion: v1 | ||
| kind: ConfigMap | ||
| metadata: | ||
| annotations: | ||
| openshift.io/description: This ConfigMap is used for Prometheus monitoring of the GitOps Operator. | ||
| openshift.io/display-name: GitOps Operator Prometheus Monitor ConfigMap | ||
| openshift.io/owning-component: service-ca | ||
| service.beta.openshift.io/inject-cabundle: "true" | ||
| name: metrics-monitor-ca-bundle | ||
| namespace: openshift-gitops-operator | ||
| --- | ||
| apiVersion: monitoring.coreos.com/v1 | ||
| kind: ServiceMonitor | ||
| metadata: | ||
| name: metrics-monitor | ||
| namespace: openshift-gitops-operator | ||
| labels: | ||
| control-plane: gitops-operator | ||
| name: metrics-monitor | ||
| namespace: system | ||
| spec: | ||
| selector: | ||
| matchLabels: | ||
| control-plane: gitops-operator | ||
| endpoints: | ||
| - bearerTokenFile: /var/run/secrets/kubernetes.io/serviceaccount/token | ||
| path: /metrics | ||
| - bearerTokenSecret: | ||
| name: openshift-gitops-operator-metrics-bearer-token | ||
| key: token | ||
| interval: 30s | ||
| path: /metrics | ||
| port: metrics | ||
| scheme: https | ||
| tlsConfig: | ||
| caFile: /etc/prometheus/configmaps/serving-certs-ca-bundle/service-ca.crt | ||
| ca: | ||
| configMap: | ||
| name: openshift-gitops-operator-metrics-monitor-ca-bundle | ||
| key: service-ca.crt | ||
| serverName: openshift-gitops-operator-metrics-service.openshift-gitops-operator.svc | ||
| selector: | ||
| matchLabels: | ||
| control-plane: gitops-operator |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be name this as
openshift-gitops-operator-metrics-monitor-bearer-tokenfor consistency ? Sorry, I should have requested this before merging.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure sid, will do and create a pr