-
Notifications
You must be signed in to change notification settings - Fork 344
fix: openshift-gitops-operator-metrics-monitor ServiceMonitor is attempting to use a bearerTokenFile configuration in its endpoints definition #1005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…mpting to use a bearerTokenFile configuration in its endpoints definition Signed-off-by: akhil nittala <nakhil@redhat.com>
|
Skipping CI for Draft Pull Request. |
…mpting to use a bearerTokenFile configuration in its endpoints definition Signed-off-by: akhil nittala <nakhil@redhat.com>
…mpting to use a bearerTokenFile configuration in its endpoints definition Signed-off-by: akhil nittala <nakhil@redhat.com>
…mpting to use a bearerTokenFile configuration in its endpoints definition Signed-off-by: akhil nittala <nakhil@redhat.com>
…mpting to use a bearerTokenFile configuration in its endpoints definition Signed-off-by: akhil nittala <nakhil@redhat.com>
|
/retest |
|
/retest-required |
…mpting to use a bearerTokenFile configuration in its endpoints definition Signed-off-by: akhil nittala <nakhil@redhat.com>
anandf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
svghadi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: svghadi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick v1.19 |
|
@svghadi: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
e941094
into
redhat-developer:master
|
@svghadi: new pull request created: #1014 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@svghadi: #1005 failed to apply on top of branch "v1.18": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@svghadi: #1005 failed to apply on top of branch "v1.17": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| metadata: | ||
| annotations: | ||
| kubernetes.io/service-account.name: openshift-gitops-operator-controller-manager | ||
| name: openshift-gitops-operator-metrics-bearer-token |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be name this as openshift-gitops-operator-metrics-monitor-bearer-token for consistency ? Sorry, I should have requested this before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure sid, will do and create a pr
What type of PR is this?
/kind bug
What does this PR do / why we need it:
The latest Prometheus upgrade enforces stricter security practices by requiring the use of Secrets and ConfigMaps for bearer tokens and TLS CA configurations. However, our current implementation references bearerTokenFile and tlsConfig.caFile using absolute filesystem paths. This approach is no longer permitted, as Prometheus now prohibits direct filesystem access for these files. As a result, the Prometheus Operator logs show errors when it attempts to access these paths.
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
https://issues.redhat.com/browse/GITOPS-7992
Fixes #?
https://issues.redhat.com/browse/GITOPS-7992
Test acceptance criteria:
How to test changes / Special notes to the reviewer:
install gitops operator on oc cluster
make this change in cluster-monitoring-configmap like below