Skip to content

Fix nightly workflow failures: BUILD_VERSION context and Node.js compatibility #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 11, 2025
Merged

Fix nightly workflow failures: BUILD_VERSION context and Node.js compatibility #921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c3ddc5a
fix: use github.run_number for BUILD_VERSION in nightly workflow
gavindidrichsen Aug 8, 2025
3a4fd10
fix(ci): update Node.js version from 18 to 20 for vsce compatibility
gavindidrichsen Aug 11, 2025
7f67e5b
Update vscode-ci workflow to use Node.js 20
gavindidrichsen Aug 11, 2025
89a1cf6
Update all workflows to use Node.js 20 for undici compatibility
gavindidrichsen Aug 11, 2025
5314644
Fix some syntax warnings.
gavindidrichsen Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/mend.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ jobs:
steps:
- uses: actions/checkout@v4

- name: 'setup node: 18 platform: ${{ runner.os }}'
- name: 'setup node: 20 platform: ${{ runner.os }}'
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20

- name: npm install
run: |
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
node-version: [18]
node-version: [20]
os: [ubuntu-latest, windows-latest, macos-latest]

steps:
Expand Down Expand Up @@ -62,7 +62,7 @@ jobs:

- name: npm test
env:
BUILD_VERSION: '0.99.${{ github.event.number }}'
BUILD_VERSION: 0.99.${{ github.run_number }}
VSCODE_BUILD_VERBOSE: true
DISPLAY: ':99.0'
shell: pwsh
Expand All @@ -72,7 +72,7 @@ jobs:
- name: vsce package
if: runner.os == 'Linux'
env:
BUILD_VERSION: '0.99.${{ github.event.number }}'
BUILD_VERSION: 0.99.${{ github.run_number }}
shell: pwsh
run: |
invoke-psake -properties @{ packageVersion = $env:BUILD_VERSION } -tasklist bump
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
workflow_dispatch:

env:
NODE_VERSION: '18.x'
NODE_VERSION: '20'

jobs:
release:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release_prep.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
name: "Release Prep"
runs-on: "ubuntu-latest"
env:
NODE_VERSION: "18"
NODE_VERSION: "20"

steps:
- name: "Checkout"
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/vscode-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,15 @@ on:
- "main"
workflow_dispatch:

env:
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

jobs:
build:
runs-on: ${{ matrix.os }}
strategy:
matrix:
node-version: [18]
node-version: [20]
os: [ubuntu-latest, windows-latest, macos-latest]

steps:
Expand Down Expand Up @@ -76,16 +76,16 @@ jobs:
npm run test:coverage

- name: Upload Coverage
if: |
runner.os == 'Linux' &&
if: |
runner.os == 'Linux' &&
env.CODECOV_TOKEN != ''
uses: codecov/codecov-action@v4
with:
token: ${{ secrets.CODECOV_TOKEN }}
files: ./coverage.xml
fail_ci_if_error: true
verbose: true

- name: vsce package
if: runner.os == 'Linux'
env:
Expand Down
Loading