Fix nightly workflow failures: BUILD_VERSION context and Node.js compatibility #921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves npm version error in scheduled runs where github.event.number is undefined, causing invalid version string "0.99." Signed-off-by: Gavin Didrichsen <gavin.didrichsen@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #921 +/- ##
=======================================
Coverage 77.77% 77.77%
=======================================
Files 1 1
Lines 9 9
=======================================
Hits 7 7
Misses 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Resolves undici dependency compatibility issue where vsce packaging fails with "File is not defined" errors. The vsce tool's cheerio dependency pulls in undici v7.13.0+ which requires Node.js 20.18.1+ but workflow was using Node.js 18.20.8. Signed-off-by: Gavin Didrichsen <gavin.didrichsen@gmail.com>
- Changes vscode-ci.yml matrix from node-version [18] to [20] - Resolves undici v7.13.0 compatibility issue in PR workflows - Aligns PR workflow with nightly workflow Node.js version - Fixes vsce packaging failure: 'File is not defined' error
Signed-off-by: Gavin Didrichsen <gavin.didrichsen@gmail.com>
gavindidrichsen
changed the title
gavindidrichsen
force-pushed
the
fix_nightly_failure_npm_version
branch
from
0efb464 to
89a1cf6
Compare
Signed-off-by: Gavin Didrichsen <gavin.didrichsen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems
The nightly CI workflow fails due to two separate but related issues:
Invalid npm version on scheduled runs -
github.event.numberis undefined for cron triggers, causingnpm error Invalid version: 0.99.Changed
BUILD_VERSIONfrom'0.99.${{ github.event.number }}'to0.99.${{ github.run_number }}.github.run_numberis available for all workflow trigger types (scheduled, manual, PR) providing consistent versioning:0.99.{run_number}across all triggersNode.js/undici compatibility failure - vsce packaging fails with
ReferenceError: File is not defineddue to undici v7.13.0 requiring Node.js 20.18.1+Initially updated nightly.yml
node-version: [18]to[20]and PR checks vscode-ci.yml. When these all passed, then I updated all the other workflows to node 20 too, e.g., mend.yml, release_prep.yml, and release.yml.