-
Notifications
You must be signed in to change notification settings - Fork 811
Add github actions workflow for testing PRs #959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sysadmind
merged 3 commits into
prometheus-community:master
from
sysadmind:github-actions
Dec 14, 2024
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,102 @@ | ||
| --- | ||
| name: CI | ||
| on: | ||
| pull_request: | ||
| push: | ||
|
|
||
| jobs: | ||
| test_go: | ||
| name: Go tests | ||
| runs-on: ubuntu-latest | ||
| container: | ||
| # Whenever the Go version is updated here, .promu.yml | ||
| # should also be updated. | ||
| image: quay.io/prometheus/golang-builder:1.23-base | ||
| steps: | ||
| - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| - uses: prometheus/promci@52c7012f5f0070d7281b8db4a119e21341d43c91 # v0.4.5 | ||
| - uses: ./.github/promci/actions/setup_environment | ||
| - run: make GO_ONLY=1 SKIP_GOLANGCI_LINT=1 | ||
|
|
||
| build: | ||
| name: Build Prometheus for common architectures | ||
| runs-on: ubuntu-latest | ||
| if: | | ||
| !(github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v')) | ||
| && | ||
| !(github.event_name == 'pull_request' && startsWith(github.event.pull_request.base.ref, 'release-')) | ||
| && | ||
| !(github.event_name == 'push' && github.event.ref == 'refs/heads/main') | ||
| && | ||
| !(github.event_name == 'push' && github.event.ref == 'refs/heads/master') | ||
| strategy: | ||
| matrix: | ||
| thread: [ 0, 1, 2 ] | ||
| steps: | ||
| - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| - uses: prometheus/promci@52c7012f5f0070d7281b8db4a119e21341d43c91 # v0.4.5 | ||
| - uses: ./.github/promci/actions/build | ||
| with: | ||
| promu_opts: "-p linux/amd64 -p windows/amd64 -p linux/arm64 -p darwin/amd64 -p darwin/arm64 -p linux/386" | ||
| parallelism: 3 | ||
| thread: ${{ matrix.thread }} | ||
|
|
||
| build_all: | ||
| name: Build Prometheus for all architectures | ||
| runs-on: ubuntu-latest | ||
| if: | | ||
| (github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v')) | ||
| || | ||
| (github.event_name == 'pull_request' && startsWith(github.event.pull_request.base.ref, 'release-')) | ||
| || | ||
| (github.event_name == 'push' && github.event.ref == 'refs/heads/main') | ||
| || | ||
| (github.event_name == 'push' && github.event.ref == 'refs/heads/master') | ||
| strategy: | ||
| matrix: | ||
| thread: [ 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11 ] | ||
|
|
||
| # Whenever the Go version is updated here, .promu.yml | ||
| # should also be updated. | ||
| steps: | ||
| - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| - uses: prometheus/promci@52c7012f5f0070d7281b8db4a119e21341d43c91 # v0.4.5 | ||
| - uses: ./.github/promci/actions/build | ||
| with: | ||
| parallelism: 12 | ||
| thread: ${{ matrix.thread }} | ||
|
|
||
| publish_main: | ||
| name: Publish main branch artifacts | ||
| runs-on: ubuntu-latest | ||
| needs: [test_go, build_all] | ||
| if: | | ||
| (github.event_name == 'push' && github.event.ref == 'refs/heads/main') | ||
| || | ||
| (github.event_name == 'push' && github.event.ref == 'refs/heads/master') | ||
| steps: | ||
| - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| - uses: prometheus/promci@52c7012f5f0070d7281b8db4a119e21341d43c91 # v0.4.5 | ||
| - uses: ./.github/promci/actions/publish_main | ||
| with: | ||
| docker_hub_login: ${{ secrets.docker_hub_login }} | ||
| docker_hub_password: ${{ secrets.docker_hub_password }} | ||
| quay_io_login: ${{ secrets.quay_io_login }} | ||
| quay_io_password: ${{ secrets.quay_io_password }} | ||
|
|
||
| publish_release: | ||
| name: Publish release artefacts | ||
| runs-on: ubuntu-latest | ||
| needs: [test_go, build_all] | ||
| if: | | ||
| (github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v')) | ||
| steps: | ||
| - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| - uses: prometheus/promci@52c7012f5f0070d7281b8db4a119e21341d43c91 # v0.4.5 | ||
| - uses: ./.github/promci/actions/publish_release | ||
| with: | ||
| docker_hub_login: ${{ secrets.docker_hub_login }} | ||
| docker_hub_password: ${{ secrets.docker_hub_password }} | ||
| quay_io_login: ${{ secrets.quay_io_login }} | ||
| quay_io_password: ${{ secrets.quay_io_password }} | ||
| github_token: ${{ secrets.PROMBOT_GITHUB_TOKEN }} | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only downside to this is that this doubles the CI runs for contributors. Since this matches Both the PR and the Push.
Maybe we can figure out a filter so this doesn't happen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied this from the CI job for the prometheus repo https://github.com/prometheus/prometheus/blob/main/.github/workflows/ci.yml#L5. Does that job run twice? If this runs twice here when someone opens a PR, I'm happy to filter to the master/main branches.