Add github actions workflow for testing PRs #959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may need some more work because it's not always easy to test actions locally. Signed-off-by: Joe Adams <github@joeadams.io>
Signed-off-by: Joe Adams <github@joeadams.io>
Signed-off-by: Joe Adams <github@joeadams.io>
SuperQ
approved these changes
Dec 14, 2024
Contributor
SuperQ
left a comment
SuperQ
left a comment
There was a problem hiding this comment.
This seems fine. I wish we could make our GH actions a little less verbose.
| name: CI | ||
| on: | ||
| pull_request: | ||
| push: |
Contributor
There was a problem hiding this comment.
The only downside to this is that this doubles the CI runs for contributors. Since this matches Both the PR and the Push.
Maybe we can figure out a filter so this doesn't happen.
Contributor
Author
There was a problem hiding this comment.
I copied this from the CI job for the prometheus repo https://github.com/prometheus/prometheus/blob/main/.github/workflows/ci.yml#L5. Does that job run twice? If this runs twice here when someone opens a PR, I'm happy to filter to the master/main branches.
rtkkroland
pushed a commit
to rtkwlf/elasticsearch_exporter
that referenced
this pull request
Jan 28, 2025
* Add github actions workflow for testing PRs This may need some more work because it's not always easy to test actions locally. Signed-off-by: Joe Adams <github@joeadams.io> * Add build and publish jobs Signed-off-by: Joe Adams <github@joeadams.io> * Update main branch references with checks for master Signed-off-by: Joe Adams <github@joeadams.io> --------- Signed-off-by: Joe Adams <github@joeadams.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may need some more work because it's not always easy to test actions locally. After this runs well for all PRs and releases, I will remove the circleCI workflows.