Use /sbin/ldconfig -p to find ORACLE_HOME #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This seems quite sensible. Lets see if there is any more feedback before merging it. |
Tux
reviewed
Dec 3, 2025
Makefile.PL
Outdated
| push @oh, $1; | ||
| } | ||
| } | ||
| my $error = close $fh; |
Member
There was a problem hiding this comment.
There is no use in catching the error and then ignoring it
close $fh or warn "Closing @cmd failed: $!\n";
Makefile.PL
Outdated
| s:/lib\w*/?$:: for @oh; # remove possible trailing lib dir | ||
| } | ||
| if ( !@oh && $^O eq 'linux' && -x '/sbin/ldconfig' ) { | ||
| my $command = '/sbin/ldconfig -p'; |
Makefile.PL
Outdated
| } | ||
| if ( !@oh && $^O eq 'linux' && -x '/sbin/ldconfig' ) { | ||
| my $command = '/sbin/ldconfig -p'; | ||
| if ( open my $fh, q{-|}, $command ) { |
Member
There was a problem hiding this comment.
if (open my $fh, '-|', @cmd) {
local $/;
push @oh => (<$fh> =~ m{^\tlibclntsh.$so[ ].*[ ]=>[ ](/.*)/libclntsh.so$}msg);
close $fh;
}
Author
|
@Tux , thank you for your helpful feedback! |
Collaborator
|
Squashing in to one commit would be better. Then we can cleanly pull the changes. |
Incorporating @Tux's feedback
Author
|
@djzort, the two commits have been squashed into one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Debian and derivatives, Oracle Instant Client installation is simplest with ZIP files and ldconfig.
No RPMs and no Alien.
Then neither ORACLE_HOME nor LDCONFIG are necessary.