Incorporate tux's feedback

Author: lewart03

Makefile.PL

@@ -958,17 +958,15 @@ sub find_oracle_home {
         s:/lib\w*/?$:: for @oh; # remove possible trailing lib dir
     }
     if ( !@oh && $^O eq 'linux' && -x '/sbin/ldconfig' ) {
-        my $command = '/sbin/ldconfig -p';
-        if ( open my $fh, q{-|}, $command ) {
-            while (<$fh>) {
-                if (m{^\tlibclntsh.$so[ ].*[ ]=>[ ](/.*)/libclntsh.so$}msx) {
-                    push @oh, $1;
-                }
-            }
-            my $error = close $fh;
+        my @cmd = qw( /sbin/ldconfig -p );
+        if ( open my $fh, '-|', @cmd ) {
+            local $/;
+            push @oh => ( <$fh> =~
+                  m{^\tlibclntsh.$so[ ].*[ ]=>[ ](/.*)/libclntsh.so$}msg );
+            close $fh or warn "Closing @cmd failed: $!\n";
         }
         else {
-            warn "Cannot run: $command\n";
+            warn "Cannot run: @cmd\n";
         }
     }
     if (!@oh) { # else try the traditional kind of install