Skip to content

ci: Fix indentation on ci.yml; update jaeger exporter tested ruby environments #1965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 24, 2025
Merged

ci: Fix indentation on ci.yml; update jaeger exporter tested ruby environments #1965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2eac6e4
ci: Fix indentation on ci.yml
kaylareopelle Nov 21, 2025
4db07ed
ci: exclude jaeger exporter from all runs except ruby 3.1, jruby
kaylareopelle Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 18 additions & 11 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,23 +99,29 @@ jobs:
# Doesn't build on macos
- os: macos-latest
gem: opentelemetry-exporter-jaeger
# Windows runs Ruby 3.4, which isn't compatible with this gem
- os: windows-latest
gem: opentelemetry-exporter-jaeger
- os: windows-latest
gem: opentelemetry-exporter-otlp-grpc
name: ${{ matrix.gem }} / ${{ matrix.os }}
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v2
- name: "Test Ruby 3.4"
if: "${{ matrix.gem != 'opentelemetry-exporter-jaeger' }}"
uses: ./.github/actions/test_gem
with:
gem: "${{ matrix.gem }}"
ruby: "3.4"
- name: "Test Ruby 3.3"
if: "${{ matrix.gem != 'opentelemetry-exporter-jaeger' }}"
uses: ./.github/actions/test_gem
with:
gem: "${{ matrix.gem }}"
ruby: "3.3"
- name: "Test Ruby 3.2"
if: "${{ matrix.gem != 'opentelemetry-exporter-jaeger' }}"
uses: ./.github/actions/test_gem
with:
gem: "${{ matrix.gem }}"
Expand All @@ -130,23 +136,24 @@ jobs:
rubocop: true
build: true
- name: "Test Zipkin with JRuby"
if: "${{ matrix.os == 'ubuntu-latest' && matrix.gem == 'opentelemetry-exporter-zipkin' }}"
uses: ./.github/actions/test_gem
with:
gem: "${{ matrix.gem }}"
ruby: "jruby"
if: "${{ matrix.os == 'ubuntu-latest' && matrix.gem == 'opentelemetry-exporter-zipkin' }}"
uses: ./.github/actions/test_gem
with:
gem: "${{ matrix.gem }}"
ruby: "jruby"
- name: "Test Jaeger with JRuby"
if: "${{ matrix.os == 'ubuntu-latest' && matrix.gem == 'opentelemetry-exporter-jaeger' }}"
uses: ./.github/actions/test_gem
with:
gem: "${{ matrix.gem }}"
ruby: "jruby-9.4"
if: "${{ matrix.os == 'ubuntu-latest' && matrix.gem == 'opentelemetry-exporter-jaeger' }}"
uses: ./.github/actions/test_gem
with:
gem: "${{ matrix.gem }}"
ruby: "jruby-9.4"
- name: "Truffleruby Filter"
id: truffleruby_skip
shell: bash
run: |
echo "skip=false" >> $GITHUB_OUTPUT
[[ "${{ matrix.gem }}" == "opentelemetry-exporter-otlp-grpc" ]] && echo "skip=true" >> $GITHUB_OUTPUT
[[ "${{ matrix.gem }}" == "opentelemetry-exporter-otlp-grpc" ]] && echo "skip=true" >> $GITHUB_OUTPUT
[[ "${{ matrix.gem }}" == "opentelemetry-exporter-jaeger" ]] && echo "skip=true" >> $GITHUB_OUTPUT
# This is essentially a bash script getting evaluated, so we need to return true or the whole job fails.
true
- name: "Test truffleruby"
Expand Down
2 changes: 2 additions & 0 deletions exporter/jaeger/.rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,5 @@ Metrics/BlockLength:
Naming/FileName:
Exclude:
- "lib/opentelemetry-exporter-jaeger.rb"
Gemspec/RequiredRubyVersion:
Severity: info