Skip to content

Align logging with default convention #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 25, 2025
Merged

Align logging with default convention #213

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5c6bac4
Align logging with other convention
pcallewaert May 26, 2025
b616b93
feat: AWS IAM RDS database authentication (#249)
tkcontiant Sep 24, 2025
dfabefa
Add e2e tests
pcallewaert Sep 22, 2025
46d84ea
Use stable go-version for tests (#238)
pcallewaert Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/controller/postgres_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ func (r *PostgresReconciler) Reconcile(ctx context.Context, req ctrl.Request) (c
}
}

reqLogger.Info("reconciler done", "CR.Namespace", instance.Namespace, "CR.Name", instance.Name)
reqLogger.Info("Reconciling done")
Copy link
Member

@hitman99 hitman99 Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this should be upper case

Copy link
Contributor Author

@pcallewaert pcallewaert Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a preference, I just aligned it with the log that mentions the starting of the reconcile.
https://github.com/movetokube/postgres-operator/blob/master/internal/controller/postgres_controller.go#L60

Copy link
Member

@hitman99 hitman99 Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. I only commented because my IDE get's angry if I want to log something starting with an uppercase letter 😅

return ctrl.Result{}, nil
}
func (r *PostgresReconciler) addFinalizer(reqLogger logr.Logger, m *dbv1alpha1.Postgres) error {
Expand Down
2 changes: 1 addition & 1 deletion internal/controller/postgresuser_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ func (r *PostgresUserReconciler) Reconcile(ctx context.Context, req ctrl.Request
return r.requeue(ctx, instance, err)
}

reqLogger.Info("reconciler done", "CR.Namespace", instance.Namespace, "CR.Name", instance.Name)
reqLogger.Info("Reconciling done")
return ctrl.Result{}, nil
}

Expand Down