Align logging with default convention #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcallewaert
force-pushed
the
chore/align-logging
branch
from
81db9a7 to
e069a50
Compare
pcallewaert
force-pushed
the
chore/align-logging
branch
from
e069a50 to
4d3a87f
Compare
pcallewaert
force-pushed
the
chore/align-logging
branch
from
4d3a87f to
5c6bac4
Compare
hitman99
reviewed
Sep 24, 2025
| } | ||
|
|
||
| reqLogger.Info("reconciler done", "CR.Namespace", instance.Namespace, "CR.Name", instance.Name) | ||
| reqLogger.Info("Reconciling done") |
Member
There was a problem hiding this comment.
I'm not sure this should be upper case
Contributor
Author
There was a problem hiding this comment.
I don't have a preference, I just aligned it with the log that mentions the starting of the reconcile.
https://github.com/movetokube/postgres-operator/blob/master/internal/controller/postgres_controller.go#L60
Member
There was a problem hiding this comment.
Fair enough. I only commented because my IDE get's angry if I want to log something starting with an uppercase letter 😅
hitman99
approved these changes
Sep 24, 2025
* feat: Helm-Chart Support External Secret Operator / feat: support for reload when secret changed * Update charts/ext-postgres-operator/values.yaml Co-authored-by: Pieter C <pieter@buca.be> * fix: values.yaml after code-review * fix: values.yaml after code-review :02 * fix: values.yaml after code-review :03 * fix: .Values.externalSecret * feat: Enable / Disable AWS IAM Authentication * fix: wrong ignore of cmd/ * fix: wrong ignore of cmd/ * Update internal/controller/postgresuser_controller.go Co-authored-by: Pieter C <pieter@buca.be> * Update internal/controller/postgresuser_controller.go Co-authored-by: Pieter C <pieter@buca.be> * feat: use already provided GrantRole and RevokeRole * feat: use already provided GrantRole and RevokeRole * Update internal/controller/postgresuser_controller.go Co-authored-by: Pieter C <pieter@buca.be> * feat: fmt internal/controller/postgresuser_controller.go * feat: change spec.aws: to include all future aws related settings --------- Co-authored-by: Pieter C <pieter@buca.be>
* Use stable go-version for tests * Fix to be able to build on v1.25
tkcontiant
pushed a commit
to tkcontiant/postgres-operator
that referenced
this pull request
Sep 25, 2025
* Align logging with other convention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor chore, but we have now duplicate entries in the logging. I also noticed that the alignment is off when passing extra args, so this should also fix it.