Skip to content

fix: don't apply getters if defaultLeanOptions is set but lean is false #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vkarpov15 merged 2 commits into from
May 12, 2025
Merged

fix: don't apply getters if defaultLeanOptions is set but lean is false #48

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5f5afe
fix: don't apply getters if defaultLeanOptions is set but lean is false
vkarpov15 May 12, 2025
5a24900
Update index.js
vkarpov15 May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,11 @@ function applyGetters(schema, res) {
if (res == null) {
return;
}
if (!this._mongooseOptions?.lean) {
return;
}
const { defaultLeanOptions } = this._mongooseLeanGettersOptions;
const shouldCallGetters = this._mongooseOptions?.lean?.getters ?? defaultLeanOptions?.getters ?? false;
const shouldCallGetters = this._mongooseOptions.lean.getters ?? defaultLeanOptions?.getters ?? false;

if (shouldCallGetters) {
if (Array.isArray(res)) {
Expand Down
7 changes: 6 additions & 1 deletion test/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,7 +442,8 @@ describe('mongoose-lean-getters', function() {
assert.equal(typeof found.discriminatedProp.num, 'string', 'Discriminated prop is not a string');
assert.equal(typeof found.discriminatedArray[0].num, 'string', 'Discriminated array is not a string');
});
it('allows defaultLeanOptions to be set and overridden at call time (#33)', async() => {

it('allows defaultLeanOptions to be set and overridden at call time (#33) (#46)', async() => {
const testSchema = new mongoose.Schema({
field: {
type: String,
Expand All @@ -458,6 +459,10 @@ describe('mongoose-lean-getters', function() {

const doc2 = await TestModel.findById(entry._id).lean({ getters: false });
assert.equal(doc2.field, 'value');

const doc3 = await TestModel.findById(entry._id);
assert.equal(doc3.field, 'value-suffix');
assert.equal(doc3.get('field', null, { getters: false }), 'value');
});

it('should allow non-discriminated documents to be retrieved (#39)', async() => {
Expand Down
Loading