fix: don't apply getters if defaultLeanOptions is set but lean is false #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes an issue where getters were applied even when lean was false despite defaultLeanOptions specifying getters. The key changes are:
- Add an explicit early return in applyGetters when lean is false.
- Update the getter computation logic to rely on the guarantee that lean is enabled.
- Extend test coverage to validate behavior with and without explicit lean options.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/index.test.js | Updated test case description and added assertions for fix (#46). |
| index.js | Added an early return for non-lean queries and removed extra optional chaining. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #46
Summary
#46 points out that setting
defaultLeanOptions: { getters: true }does apply getters even ifleanis not set, which can be problematic.Examples