-
Notifications
You must be signed in to change notification settings - Fork 90
feat: handle deep links to commands VSCODE-683 VSCODE-684 VSCODE-685 #995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* main: chore(telemetry): append user anonymousId & connectionId to appName passed to server COMPASS-8591 (#982) chore(deps): bump @mongodb-js/connection-info from 0.11.5 to 0.11.6 (#992) chore(deps): bump @mongodb-js/mongodb-constants from 0.10.4 to 0.11.0 (#991) chore(deps): bump mongodb from 6.14.2 to 6.15.0 in the driver group (#990) chore(deps): bump mongodb-schema from 12.5.0 to 12.5.2 (#988)
gagik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable, minor note about the URL format.
cveticm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the quick work and all the additions! 🚀
cveticm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀 Thanks for adding telem and warning messaging!
Description
Adds a URI handler that can be invoked with a command and optional query arguments, which will then execute said command. The following commands have been updated to accept arguments:
connectWithURIconnectionString: connection string to connect with. If not supplied, a prompt will be shownreuseExisting: true/false whether to always create a new connection or connect to an existing one with matching connection string.name: optional name to assign to the connectionremoveConnection- only one ofid/name/connectionStringmust be providedconnectionString: connection string to removename: name of connection to removeid: id of connection to removeforce: true/false whether to prompt the user before removingThe URI handler will:
pathwill be mapped tocommand. Themdb.prefix will be automatically added if not present, so both/connectWithURIand/mdb.connectWithURIresolve to the same command.querywill be mapped to aparamsobject which will be supplied as the only argument toexecuteCommand. Numbers and booleans will be parsed to their corresponding data type, everything else will be mapped to a string.Deep Link Handled{ command: string, source?: string }sourceis populated by theutm_sourcequery argument, which is removed from the params passed to the command after it has been processed.Checklist
Motivation and Context
Types of changes