Skip to content

Conversation

@himanshusinghs
Copy link
Contributor

@himanshusinghs himanshusinghs commented Nov 3, 2025

Description

This PR adds a 7 days of cooldown for dependabot before pulling updates for npm dependencies. The cooldown is to provide a little shield period until a malicious package is identified before getting merged in our releasable code.

Additionally addresses VSCODE-708

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@himanshusinghs himanshusinghs requested a review from a team as a code owner November 3, 2025 12:28
Copilot AI review requested due to automatic review settings November 3, 2025 12:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies CI/CD workflows to disable code health runs on fork PRs while maintaining them for Dependabot, and adds a 7-day cooldown period for all Dependabot updates to reduce update frequency.

Key changes:

  • Restricts the test-and-build workflow to run only for Dependabot PRs, excluding fork PRs
  • Implements a 7-day cooldown for all Dependabot dependency updates

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/test-and-build-from-fork.yaml Modified workflow trigger condition to exclude fork PRs while keeping Dependabot support
.github/dependabot.yml Added cooldown configuration to limit Dependabot update frequency

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@himanshusinghs himanshusinghs added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Nov 3, 2025
@addaleax

This comment was marked as resolved.

@himanshusinghs himanshusinghs changed the title chore: disable code health runs on forks and add dependabot cooldown chore: disable code health runs on forks and add dependabot cooldown VSCODE-708 Nov 3, 2025
1. Removes excessive permissions from workflow expected to run on forked
   and dependabot PRs
2. Change the trigger of workflow intended for forked PRs to use
   pull_request instead of pull_request_trigger, aiming to not
   un-intentionally expose secrets.
3. Split the auto-merge step for dependabot PRs that require
   pull_request_target trigger into a separate workflow.
@himanshusinghs himanshusinghs changed the title chore: disable code health runs on forks and add dependabot cooldown VSCODE-708 chore: reconfigures workflow for dependabot and forked PRs VSCODE-708 Nov 5, 2025
@himanshusinghs himanshusinghs merged commit 5bb8fca into main Nov 5, 2025
15 checks passed
@himanshusinghs himanshusinghs deleted the chore/ci-work branch November 5, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants