-
Notifications
You must be signed in to change notification settings - Fork 84
test: Re-apply streams e2e test and add retries to commands MONGOSH-2300 #2484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
41d71a4 to
2fe4bed
Compare
| const { | ||
| STREAMS_E2E_SPI_CONNECTION_STRING = '', | ||
| STREAMS_E2E_DB_USER = '', | ||
| STREAMS_E2E_DB_PASSWORD = '', | ||
| STREAMS_E2E_CLUSTER_CONNECTION_STRING = '', | ||
| } = process.env; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something that confuses me is that between the OG commit and the revert, the .evergreen.yml got updated by a bot which removed my env vars from .evergreen.yml, so reapplying the commit didn't put them back. However, the tests still seem to run, even though they should skip and log that if the right variables aren't present. So I guess having the right values in project settings without specifying them in the .evergreen.yml is sufficient?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to add them to .evergreen/evergreen.yml.in, which the .evergreen.yml file is generated from
Having them in the project settings may currently work as a way of passing these env vars, but I'd definitely prefer to use an explicit way of passing them if we can
4b3ae73 to
03b4abd
Compare
|
Assigned |
|
Just confirming in the latest Evergreen run, none of the e2e failures have to do with the Streams tests in this PR |
357efa4 to
49198f6
Compare
|
Quick bump on this @himanshusinghs @mongodb-js/mongosh-developers, would appreciate a review when you get a chance 🙏🏾 thanks in advance! |
49198f6 to
218af9a
Compare
218af9a to
f6d2fd3
Compare
gagik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not very familiar with streams but code looks reasonable to me.
No description provided.