chore: split connect and switch-connection tool MCP-301 #749
+119
−129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the connection management in the MCP server by splitting the dual-purpose connect/switch-connection tool into two separate tools that enable/disable based on connection state. Instead of dynamically updating a single tool's metadata, there are now distinct connect and switch-connection tools.
Key Changes:
- Replaced dynamic tool metadata updating with enable/disable functionality
- Created separate
SwitchConnectionToolclass for switching connections - Removed complex update logic from
ToolBasethat worked around upstream SDK bugs
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/tools/tool.ts | Removed custom update() method and added enable()/disable() methods to control tool visibility |
| src/tools/mongodb/connect/connect.ts | Simplified ConnectTool to only handle initial connection, using enable/disable instead of metadata updates |
| src/tools/mongodb/connect/switchConnection.ts | New tool for switching connections when already connected |
| src/tools/mongodb/tools.ts | Added SwitchConnectionTool to the tool registry |
| tests/integration/tools/mongodb/connect/connect.test.ts | Updated test to reflect new connection string description |
| src/common/logger.ts | Added new log ID for tool metadata changes |
Collaborator
Pull Request Test Coverage Report for Build 19641075675Details
💛 - Coveralls |
gagik
approved these changes
Nov 24, 2025
himanshusinghs
deleted the
chore/MCP-301-split-connect-and-switch-connection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR splits connect and switch-connection tool into two different tools that are enabled / disabled based on whether a connection is established or not.
Checklist