Skip to content

chore: Clean up unused _data_availability #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsonbailey merged 1 commit into from
Dec 1, 2025
Merged

chore: Clean up unused _data_availability #383

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions ldclient/impl/datasystem/fdv1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@
from ldclient.impl.listeners import Listeners
from ldclient.impl.stubs import NullUpdateProcessor
from ldclient.interfaces import (
DataSourceState,
DataSourceStatus,
DataSourceStatusProvider,
DataStoreStatusProvider,
FeatureStore,
Expand Down Expand Up @@ -84,20 +82,6 @@ def __init__(self, config: Config):
# Diagnostic accumulator provided by client for streaming metrics
self._diagnostic_accumulator: Optional[DiagnosticAccumulator] = None

# Track current data availability
self._data_availability: DataAvailability = (
DataAvailability.CACHED
if getattr(self._store_wrapper, "initialized", False)
else DataAvailability.DEFAULTS
)

# React to data source status updates to adjust availability
def _on_status_change(status: DataSourceStatus):
if status.state == DataSourceState.VALID:
self._data_availability = DataAvailability.REFRESHED

self._data_source_status_provider_impl.add_listener(_on_status_change)

def start(self, set_on_ready: Event):
"""
Starts the v1 update processor and returns immediately. The provided
Expand Down