-
Notifications
You must be signed in to change notification settings - Fork 0
feat: [REL-10964] add Session Replay capabilities to Toolbar #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add observability and Session Replay integration to the toolbar's internal LaunchDarkly client. Session Replay is controlled via a feature flag.
nieblara
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things are looking cool here!
| // Add Session Replay plugin with manual start | ||
| observabilityPlugins: [ | ||
| new SessionReplay({ | ||
| manualStart: true, | ||
| privacySetting: 'default', | ||
| }), | ||
| ], | ||
| } | ||
| : undefined; | ||
| : { | ||
| // Add Session Replay plugin with manual start | ||
| observabilityPlugins: [ | ||
| new SessionReplay({ | ||
| manualStart: true, | ||
| privacySetting: 'default', | ||
| }), | ||
| ], | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, non blocking: we can simplify this so we dont have branching!
const sessionReplayPlugin = new SessionReplay({
manualStart: true,
privacySetting: 'default',
});
const options = {
...(baseUrl && { baseUrl }),
...(streamUrl && { streamUrl }),
...(eventsUrl && { eventsUrl }),
observabilityPlugins: [sessionReplayPlugin],
};
| checkAndUpdateSessionReplay(); | ||
|
|
||
| // Listen for flag changes | ||
| const flagKey = 'toolbar-enable-session-replay'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: could be a constant, i see this used in packages/toolbar/src/flags/toolbarFlags.ts
|
the session replay lib might be too new for the version of the sdk we have right now! |
Add observability and Session Replay integration to the toolbar's internal LaunchDarkly client. Session Replay is controlled via a feature flag.
Description
This PR adds Session Replay capabilities to the Developer Toolbar, enabling observability.
What does this PR do?
Integrates LaunchDarkly's Session Replay plugin into the toolbar's internal client, controlled by a feature flag. Session Replay runs only in the toolbar's internal LaunchDarkly client context and uses the 'default' privacy setting.
Type of Change
Screenshots/Videos
Related Jira issue: REL-10964: Add Session Replay capabilities to the Developer Toolbar