interface: start/stop API for updateRun #314
Open
+83
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
.github/.copilot/breadcrumbs/2025-10-29-1500-start-stop-updaterun-api.md
Outdated
Show resolved
Hide resolved
added 10 commits
November 6, 2025 15:08
Signed-off-by: Arvind Thirumurugan <arvindth@microsoft.com>
Signed-off-by: Arvind Thirumurugan <arvindth@microsoft.com>
Signed-off-by: Arvind Thirumurugan <arvindth@microsoft.com>
Signed-off-by: Arvind Thirumurugan <arvindth@microsoft.com>
Signed-off-by: Arvind Thirumurugan <arvindth@microsoft.com>
Signed-off-by: Arvind Thirumurugan <arvindth@microsoft.com>
Signed-off-by: Arvind Thirumurugan <arvindth@microsoft.com>
Arvindthiru
force-pushed
the
startStopAPI
branch
from
e48206a to
96621fc
Compare
Signed-off-by: Arvind Thirumurugan <arvindth@microsoft.com>
|
|
||
| const ( | ||
| // StateNotStarted indicates the update run has been initialized but execution has not started. | ||
| // This is the default state after initialization completes. |
Contributor
There was a problem hiding this comment.
The state here is the "desired" state set by the user but the whole description makes this look like a status instead of spec.
| PlacementName: crpName, | ||
| ResourceSnapshotIndex: resourceSnapshotIndex, | ||
| StagedUpdateStrategyName: strategyName, | ||
| State: placementv1beta1.StateStarted, |
Contributor
There was a problem hiding this comment.
shouldn't the default be "stateNotStarted"? It's the default so we don't need to add it?
Collaborator
Author
There was a problem hiding this comment.
Field validation fails if value is state is not specified
I tried applying the object using an yaml file it set the default value correctly but when it's go struct field validation kicks in before the default value is set. Since our updateRuns start by default I set it to StateStarted for now
added 6 commits
November 7, 2025 12:14
Signed-off-by: Arvind Thirumurugan <arvindth@microsoft.com>
Signed-off-by: Arvind Thirumurugan <arvindth@microsoft.com>
Signed-off-by: Arvind Thirumurugan <arvindth@microsoft.com>
Signed-off-by: Arvind Thirumurugan <arvindth@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR aims to add new API changes to allow users to set the following intent on an updateRun,
Adding a new spec field called state which is an enum
Adding another condition type for updateRun status called Abandoned
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer