fix states

Signed-off-by: Arvind Thirumurugan <arvindth@microsoft.com>

Author: Arvind Thirumurugan

apis/placement/v1beta1/stageupdate_types.go

@@ -157,14 +157,14 @@ const (
 	// This is the default state after initialization completes.
 	StateNotStarted State = "NotStarted"
 
-	// StateStart indicates the update run should execute (or resume execution if paused).
-	StateStart State = "Start"
+	// StateStarted indicates the update run should execute (or resume execution if paused).
+	StateStarted State = "Started"
 
-	// StateStop indicates the update run should pause execution.
-	StateStop State = "Stop"
+	// StateStopped indicates the update run should pause execution.
+	StateStopped State = "Stopped"
 
-	// StateAbandon indicates the update run should be abandoned and terminated.
-	StateAbandon State = "Abandon"
+	// StateAbandoned indicates the update run should be abandoned and terminated.
+	StateAbandoned State = "Abandoned"
 )
 
 // UpdateRunSpec defines the desired rollout strategy and the snapshot indices of the resources to be updated.
@@ -191,9 +191,9 @@ type UpdateRunSpec struct {
 
 	// State indicates the desired state of the update run.
 	// NotStarted: The update run is initialized but execution has not started (default).
-	// Start: The update run should execute or resume execution.
-	// Stop: The update run should pause execution.
-	// Abandon: The update run should be abandoned and terminated.
+	// Started: The update run should execute or resume execution.
+	// Stopped: The update run should pause execution.
+	// Abandoned: The update run should be abandoned and terminated.
 	// +kubebuilder:validation:Optional
 	// +kubebuilder:validation:Enum=NotStarted;Start;Stop;Abandon
 	// +kubebuilder:default=NotStarted

config/crd/bases/placement.kubernetes-fleet.io_clusterstagedupdateruns.yaml

@@ -1181,9 +1181,9 @@ spec:
                 description: |-
                   State indicates the desired state of the update run.
                   NotStarted: The update run is initialized but execution has not started (default).
-                  Start: The update run should execute or resume execution.
-                  Stop: The update run should pause execution.
-                  Abandon: The update run should be abandoned and terminated.
+                  Started: The update run should execute or resume execution.
+                  Stopped: The update run should pause execution.
+                  Abandoned: The update run should be abandoned and terminated.
                 enum:
                 - NotStarted
                 - Start

config/crd/bases/placement.kubernetes-fleet.io_stagedupdateruns.yaml

@@ -100,9 +100,9 @@ spec:
                 description: |-
                   State indicates the desired state of the update run.
                   NotStarted: The update run is initialized but execution has not started (default).
-                  Start: The update run should execute or resume execution.
-                  Stop: The update run should pause execution.
-                  Abandon: The update run should be abandoned and terminated.
+                  Started: The update run should execute or resume execution.
+                  Stopped: The update run should pause execution.
+                  Abandoned: The update run should be abandoned and terminated.
                 enum:
                 - NotStarted
                 - Start

pkg/controllers/updaterun/controller_integration_test.go

@@ -341,7 +341,7 @@ func generateTestClusterStagedUpdateRun() *placementv1beta1.ClusterStagedUpdateR
 			PlacementName:            testCRPName,
 			ResourceSnapshotIndex:    testResourceSnapshotIndex,
 			StagedUpdateStrategyName: testUpdateStrategyName,
-			State:                    placementv1beta1.StateStart,
+			State:                    placementv1beta1.StateStarted,
 		},
 	}
 }

test/apis/placement/v1beta1/api_validation_integration_test.go

@@ -1123,7 +1123,7 @@ var _ = Describe("Test placement v1beta1 API validation", func() {
 					Name: fmt.Sprintf(validupdateRunNameTemplate, GinkgoParallelProcess()),
 				},
 				Spec: placementv1beta1.UpdateRunSpec{
-					State: placementv1beta1.StateStart,
+					State: placementv1beta1.StateStarted,
 				},
 			}
 			Expect(hubClient.Create(ctx, &updateRun)).Should(Succeed())
@@ -1138,7 +1138,7 @@ var _ = Describe("Test placement v1beta1 API validation", func() {
 					Name: fmt.Sprintf(invalidupdateRunNameTemplate, GinkgoParallelProcess()),
 				},
 				Spec: placementv1beta1.UpdateRunSpec{
-					State: placementv1beta1.StateStart,
+					State: placementv1beta1.StateStarted,
 				},
 			}
 			err := hubClient.Create(ctx, &updateRun)
@@ -1154,7 +1154,7 @@ var _ = Describe("Test placement v1beta1 API validation", func() {
 				},
 				Spec: placementv1beta1.UpdateRunSpec{
 					PlacementName: "test-placement",
-					State:         placementv1beta1.StateStart,
+					State:         placementv1beta1.StateStarted,
 				},
 			}
 			Expect(hubClient.Create(ctx, &updateRun)).Should(Succeed())

test/e2e/cluster_staged_updaterun_test.go

@@ -1668,7 +1668,7 @@ func createClusterStagedUpdateRunSucceed(updateRunName, crpName, resourceSnapsho
 			PlacementName:            crpName,
 			ResourceSnapshotIndex:    resourceSnapshotIndex,
 			StagedUpdateStrategyName: strategyName,
-			State:                    placementv1beta1.StateStart,
+			State:                    placementv1beta1.StateStarted,
 		},
 	}
 	Expect(hubClient.Create(ctx, updateRun)).To(Succeed(), "Failed to create ClusterStagedUpdateRun %s", updateRunName)

test/e2e/staged_updaterun_test.go

@@ -1201,7 +1201,7 @@ func createStagedUpdateRunSucceed(updateRunName, namespace, rpName, resourceSnap
 			PlacementName:            rpName,
 			ResourceSnapshotIndex:    resourceSnapshotIndex,
 			StagedUpdateStrategyName: strategyName,
-			State:                    placementv1beta1.StateStart,
+			State:                    placementv1beta1.StateStarted,
 		},
 	}
 	Expect(hubClient.Create(ctx, updateRun)).To(Succeed(), "Failed to create StagedUpdateRun %s", updateRunName)